feat(helm): Add health probes to write #20087
Open
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindhe
force-pushed
the
lindhe/write-probes
branch
from
04d40b2 to
3296c66
Compare
This change adds configurable `livenessProbe` and `startupProbe` to the loki container in the write pods. Signed-off-by: Andreas Lindhé <[email protected]>
lindhe
force-pushed
the
lindhe/write-probes
branch
from
3296c66 to
03dde44
Compare
Contributor
Author
|
Rebased on main to see if that fixes the test errors. I'm not missing something here, right? Feels like these errors are not my work… 
|
Contributor
|
@lindhe There's an issue with that particular test. We're looking at a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adds configurable
livenessProbeandstartupProbeto the loki container in the write pods.Which issue(s) this PR fixes:
Not sure.
Special notes for your reviewer:
Partially replaces #15359
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR